From e445f66bdceec0264e920a0271e5ea9cfec16c72 Mon Sep 17 00:00:00 2001 From: Weedy Date: Sat, 14 Jun 2014 05:06:31 -0400 Subject: [PATCH] Use -1 to indicate the pipe is not opened 0 can be a valid FD, this removes any ambiguity. --- src/core/settings.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/settings.c b/src/core/settings.c index 46fca863..172f8e80 100644 --- a/src/core/settings.c +++ b/src/core/settings.c @@ -738,7 +738,7 @@ static void init_configfile(void) if (pipe(signal_wakeup_pipe)) { g_warning("Failed to create signal wakeup pipe - SIGTERM not attached"); - signal_wakeup_pipe[0] = 0; + signal_wakeup_pipe[0] = -1; return; } if (set_nonblock_flag(signal_wakeup_pipe[0]) || set_nonblock_flag(signal_wakeup_pipe[1])) { @@ -772,7 +772,7 @@ static void deinit_configfile(void) g_io_channel_unref(signal_wakeup_read_channel); } - if (signal_wakeup_pipe[0]) { + if (signal_wakeup_pipe[0] != -1) { close(signal_wakeup_pipe[0]); close(signal_wakeup_pipe[1]); }